Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

v1beta foldeer has been renamed to v1 so needs the path too #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

v1beta foldeer has been renamed to v1 so needs the path too #243

wants to merge 1 commit into from

Conversation

MATRIX4284
Copy link
Contributor

v1beta foldeer has been renamed to v1 so needs the path too:
new command:
kubectl create -f ./v1/pytorch_job_mnist_gloo.yaml

Inconsistent documentation

@MATRIX4284
v1beta foldeer has been renamed to v1 so needs the path too
5719fb9 
v1beta foldeer has been renamed to v1 so needs the path too:
new command:
kubectl create -f ./v1/pytorch_job_mnist_gloo.yaml

Inconsistent documentation
@k8s-ci-robot
Copy link

Hi @MATRIX4284. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 22.97% when pulling 5719fb9 on MATRIX4284:patch-1 into f117363 on kubeflow:master.

gaocegege
gaocegege reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MATRIX4284
Copy link
Contributor Author

is this pr getting merged?

@gaocegege
Copy link
Member

/retest

@Jeffwan
Copy link
Member

Jeffwan commented Oct 24, 2020

@MATRIX4284 Can you rebase master changes? We recently update test pipeline. Once rebase is done, test should pass

@aws-kf-ci-bot
Copy link

@MATRIX4284: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e 5719fb9 link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit 5719fb9 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaocegege gaocegege gaocegege left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MATRIX4284 @k8s-ci-robot @coveralls @gaocegege @Jeffwan @aws-kf-ci-bot